Skip to content

OpenCL now can run both sync/async gpu tests.#1955

Merged
rok-cesnovar merged 4 commits intodevelopfrom
separate-cicd-gpu-async
Jul 3, 2020
Merged

OpenCL now can run both sync/async gpu tests.#1955
rok-cesnovar merged 4 commits intodevelopfrom
separate-cicd-gpu-async

Conversation

@serban-nicusor-toptal
Copy link
Copy Markdown
Contributor

Summary

#1940

Separated the gpus we have as sync (AMD, mac) and async (NVIDIA, linux).
Added a new parameter gpu_async that will run the OpenCL tests on both a sync (AMD) GPU and an async (NVIDIA) one.
Added a new stage for the async gpu.
It will run on both GPUs if there are changes in ./opencl

Tests

Side Effects

Release notes

Checklist

  • Math issue #(issue number)

  • Copyright holder: (fill in copyright holder information)

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@stan-buildbot
Copy link
Copy Markdown
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.07 4.06 1.0 0.34% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.96 -4.3% slower
eight_schools/eight_schools.stan 0.09 0.09 1.03 3.38% faster
gp_regr/gp_regr.stan 0.19 0.19 1.01 0.66% faster
irt_2pl/irt_2pl.stan 5.26 5.34 0.99 -1.49% slower
performance.compilation 86.77 84.6 1.03 2.5% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.69 7.77 0.99 -1.16% slower
pkpd/one_comp_mm_elim_abs.stan 20.86 21.29 0.98 -2.05% slower
sir/sir.stan 103.77 105.02 0.99 -1.2% slower
gp_regr/gen_gp_data.stan 0.04 0.04 1.0 0.05% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 3.12 0.97 -3.34% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.33 0.33 0.99 -0.94% slower
arK/arK.stan 2.43 2.43 1.0 -0.24% slower
arma/arma.stan 0.59 0.6 0.99 -1.18% slower
garch/garch.stan 0.52 0.52 0.99 -1.19% slower
Mean result: 0.993630271694

Jenkins Console Log
Blue Ocean
Commit hash: 27ab306


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Copy link
Copy Markdown
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing and a question.

Comment thread Jenkinsfile Outdated
Copy link
Copy Markdown
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stan-buildbot
Copy link
Copy Markdown
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.05 4.0 1.01 1.25% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.97 -2.71% slower
eight_schools/eight_schools.stan 0.09 0.09 1.02 1.86% faster
gp_regr/gp_regr.stan 0.19 0.19 0.99 -0.56% slower
irt_2pl/irt_2pl.stan 5.24 5.33 0.98 -1.61% slower
performance.compilation 85.57 84.85 1.01 0.85% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.71 7.68 1.0 0.33% faster
pkpd/one_comp_mm_elim_abs.stan 20.59 21.15 0.97 -2.71% slower
sir/sir.stan 104.14 110.93 0.94 -6.52% slower
gp_regr/gen_gp_data.stan 0.04 0.04 0.99 -0.8% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 3.08 0.98 -1.96% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.31 1.0 0.16% faster
arK/arK.stan 2.42 2.43 0.99 -0.54% slower
arma/arma.stan 0.6 0.6 1.0 0.19% faster
garch/garch.stan 0.52 0.52 1.01 1.13% faster
Mean result: 0.992685924426

Jenkins Console Log
Blue Ocean
Commit hash: a578d45


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@rok-cesnovar rok-cesnovar merged commit 3ac7b31 into develop Jul 3, 2020
@rok-cesnovar rok-cesnovar deleted the separate-cicd-gpu-async branch July 3, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants